Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom DNS support #260

Closed
wants to merge 3 commits into from
Closed

Custom DNS support #260

wants to merge 3 commits into from

Conversation

sayem314
Copy link
Contributor

@sayem314 sayem314 commented Jul 18, 2018 •
edited by angristan
Loading

Followup #208

Closes #253 and #258

@angristan
Copy link
Owner

This is not related to #253 btw.

@angristan
Copy link
Owner

^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ is not a regex for IPv4

@ghost ghost deleted a comment from sayem314 Aug 23, 2018
angristan added a commit that referenced this pull request Aug 20, 2019
@angristan @sayem314
Add support for custom DNS input
7793d85 
Close #258 #260

Co-authored-by: Sayem Chowdhury <sayem314@gmail.com>
@angristan angristan mentioned this pull request Aug 20, 2019
Merged
@angristan
Copy link
Owner

angristan commented Aug 20, 2019 •
edited
Loading

I had to make another PR because of merge conflicts: #470

@angristan angristan closed this Aug 20, 2019
angristan added a commit that referenced this pull request Aug 20, 2019
@angristan @sayem314
Add support for custom DNS input (#470)
bc109db 
Close #258 #260

Co-authored-by: Sayem Chowdhury <sayem314@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a "switch DNS" menu entry (after setup)
2 participants
@sayem314 @angristan