safe get key for request.META

[talbenbasat]

No description provided.

[talbenbasat]

@anx-ckreuzberger can you please check and merge

[anx-ckreuzberger]

PR looks fine, but I'm not sure if this is a behaviour that I would want to support without notifying the dev/admin about it.

I think I'll make those "default values" configureable in Django Settings.

[talbenbasat]

sounds good added those values..
let me know if there's any way I can help

[anx-ckreuzberger]

Thanks!

[bentappin]

It might better to allow users to set the name of the header rather than providing default values if the REMOTE_ADDR is not found?

E.g. so essentially allowing to user to say "hey use HTTP_X_REAL_IP not REMOTE_ADDR please"

Perhaps something like this:

user_agent_header = getattr(settings, 'DJANGO_REST_PASSWORDRESET_HTTP_USER_AGENT_HEADER', 'HTTP_USER_AGENT')
ip_address_header = getattr(settings, 'DJANGO_REST_PASSWORDRESET_IP_ADDRESS_HEADER', 'REMOTE_ADDR')

token = ResetPasswordToken.objects.create(
    user=user,
    user_agent=request.META.get(user_agent_header),
    ip_address=request.META.get(ip_address_header)
)

[anx-ckreuzberger]

I believe the implementation suggested by @vonorm is correct, the original implementation coming from the Merge Request is faulty.