Conversation
| const { css } = require('@webpack-blocks/assets') | ||
| const path = require('path') | ||
| const precss = require('precss') | ||
| const postcssVars = require('postcss-simple-vars') |
There was a problem hiding this comment.
precss is outdated and brings lots of dependencies with itself, but its features are not required for these tests.
|
Ava fails with a weird babel error: I can also reproduce it locally on |
|
I guess the |
andywer
left a comment
andywer
left a comment
There was a problem hiding this comment.
Looks good to me 👌
Does someone else wanna have a look at the PR? 😉
|
PS: Downgrading AVA seems fine. |
|
To sum up: if you update from one of previous commits to I've downgraded |
|
Sounds good! Build is failing, though 🙃 We either need to find that dependency that's not compatible to node 6 or bump to minimum node 8. I would prefer continued support for node 6 if it's not too much effort. |
|
Damn, |
|
@andywer yeah, we should stick to what |
| "preserveConstEnums": true, | ||
| "sourceMap": true, | ||
| "target": "es5", | ||
| "target": "es2015", |
There was a problem hiding this comment.
The newest @types/node require it. Node 6 supports ES6, so it's fine.
2 participants
No description provided.