Remove css-loader and style-loader from the sass block#298
Merged
andywer merged 4 commits intoandywer:release-2.0from Oct 18, 2018
Merged
Remove css-loader and style-loader from the sass block#298andywer merged 4 commits intoandywer:release-2.0from
andywer merged 4 commits intoandywer:release-2.0from
Conversation
andywer
reviewed
Sep 29, 2018
Owner
andywer
left a comment
andywer
left a comment
There was a problem hiding this comment.
Great stuff, Marco! 😊👍
Just one minor change in phrasing from my side. Thanks a bunch!
packages/sass/README.md
Outdated
| ``` | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| **NOTE**: the `css()` block by default works on `.css` files, so you have to make it accept `.scss` |
Owner
There was a problem hiding this comment.
I‘d like to change the wording here:
"Note: Use match() here to apply the css() block to .scss files"?
vlad-zhukov
previously approved these changes
Sep 29, 2018
marcofugaro
force-pushed
the
sass-block-refactor
branch
from
64537ec to
46347b4
Compare
marcofugaro
force-pushed
the
sass-block-refactor
branch
from
46347b4 to
0be8f4c
Compare
Contributor
Author
|
@andywer I updated the wording as you asked, maybe you missed it 🙂 |
vlad-zhukov
approved these changes
Oct 18, 2018
Owner
|
I did indeed! |
andywer
approved these changes
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of discussion in #293