Skip to content

Move elm to own repo#271

Merged
vlad-zhukov merged 1 commit intoandywer:release-2.0from
zcei:refactor/move-elm-to-own-repo
Apr 25, 2018
Merged

Move elm to own repo#271
vlad-zhukov merged 1 commit intoandywer:release-2.0from
zcei:refactor/move-elm-to-own-repo

Conversation

@zcei
Copy link
Collaborator

@zcei zcei commented Apr 24, 2018

You can find it here: webpack-blocks/elm

Related PR with the e2e test: webpack-blocks/elm#1

@zcei
Copy link
Collaborator Author

zcei commented Apr 24, 2018

@vlad-zhukov I think I just decreased build time from >20min to ~5min 😀

yarn.lock Outdated
resolved "https://registry.yarnpkg.com/@types/react/-/react-15.6.15.tgz#1856f932120311aa566f91e6d0c6e613d6448236"

"@webpack-blocks/elm@^1.0.0":
version "1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did it come from? It shouldn't be here.

Copy link
Collaborator Author

@zcei zcei Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering the same, it came up after I ran yarn remove elm elm-hot-loader elm-webpack-loader within ./packages/webpack

EDIT: I forgot to remove @webpack-blocks/elm from devDependencies, good catch!

@zcei zcei force-pushed the refactor/move-elm-to-own-repo branch from 13abf6d to 9902167 Compare April 24, 2018 18:53
@vlad-zhukov
Copy link
Collaborator

I think I just decreased build time from >20min to ~5min 😀

This is awesome! 🏆 I was waiting for this for a long time, finally we can get rid of builds that take forever!

P.S. 🤓 technically builds run simultaneously so from 12-15 mins to 2-3, which is even better!

Copy link
Collaborator

@vlad-zhukov vlad-zhukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! This is another prove why moving elm block to its own repo is the right decision and very healthy for the project overall. Thank you very much, @zcei, of taking care of it!

I'd merge it right away, just want others to see this too! @andywer @jvanbruegge @dmitmel @farism

@dmitmel
Copy link
Contributor

dmitmel commented Apr 24, 2018

Awesome!

@jvanbruegge
Copy link
Contributor

The built time is quite amazing

@farism
Copy link

farism commented Apr 24, 2018

If elm was experiencing slow build times, it may have been due to invalid reporting of cores to the elm compiler which severely slows down the compiling of modules elm/compiler#1473

- [babel](./packages/babel)
- [dev-server](./packages/dev-server)
- [elm](./packages/elm)
- [elm](https://github.com/webpack-blocks/elm)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vlad-zhukov vlad-zhukov merged commit 9fc9dfd into andywer:release-2.0 Apr 25, 2018
@zcei zcei deleted the refactor/move-elm-to-own-repo branch April 25, 2018 05:33
andywer pushed a commit that referenced this pull request Jun 19, 2018
marcofugaro pushed a commit to marcofugaro/webpack-blocks that referenced this pull request Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants