Skip to content

Remove stale package-lock.json files#270

Closed
farism wants to merge 1 commit intoandywer:release-2.0from
farism:remove-npm-package-locks
Closed

Remove stale package-lock.json files#270
farism wants to merge 1 commit intoandywer:release-2.0from
farism:remove-npm-package-locks

Conversation

@farism
Copy link

@farism farism commented Apr 23, 2018

Now that webpack-blocks is using yarn workspaces we should remove any package-lock.json files that are generated by NPM. NPM technically is no longer supported by webpack-blocks.

Copy link
Collaborator

@vlad-zhukov vlad-zhukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't it covered by #268?

@zcei
Copy link
Collaborator

zcei commented Apr 24, 2018

@vlad-zhukov I thought the same, but no - #268 only removed huge parts of the package-lock, but not the file completely. That was a bit missleading from GitHub's collapsed view.

@vlad-zhukov
Copy link
Collaborator

vlad-zhukov commented Apr 24, 2018

I bet these are your local files. You can go through the release-2.0 branch on GitHub to make sure there are no package-lock.jsons left!

Git doesn't remove gitignored files when you checkout.

@andywer
Copy link
Owner

andywer commented Apr 24, 2018

@vlad-zhukov Good point! But how was @farism able to create a PR against release-2.0, deleting the lock files, if they are already removed? 🤔

@zcei
Copy link
Collaborator

zcei commented Apr 24, 2018

And to my comment from above: when you click on "View" in the files section of a PR for a deleted file, it actually shows the state before it has been removed.. doh!

@vlad-zhukov
Copy link
Collaborator

I've just made a clean git pull and the only package-lock.json left is in the eslint package. Interestingly both this PR and #268 missed it.

@vlad-zhukov
Copy link
Collaborator

vlad-zhukov commented Apr 24, 2018

Actually I was looking at a different branch, there are not package-lock.json files left in the release-2.0 branch. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants