Conversation
package.json
Outdated
| } | ||
| }, | ||
| "lint-staged": { | ||
| "*.{js,ts}": [ |
There was a problem hiding this comment.
There is a file called packages/sample-app/src/App.tsx, so the .tsx extension should also be added here
package.json
Outdated
| "scripts": { | ||
| "test": "lerna run test", | ||
| "test": "npm run format && lerna run test", | ||
| "format": "prettier --no-semi --single-quote --write 'packages/**/*.{js,ts}'", |
package.json
Outdated
| }, | ||
| "lint-staged": { | ||
| "*.{js,ts,tsx}": [ | ||
| "prettier --no-semi --single-quote --write", |
There was a problem hiding this comment.
Prettier can be configured via prettier key in the package.json, so let's move prettier config there to reduce duplication (see line 15)
|
Should we format Markdown files with Prettier? |
|
Might also make sense to use |
|
@andywer ESLint has more linting options than Standard, but for now we can use Standard. |
|
@dmitmel Of course, but I wouldn't change everything at once. Incremental changes are way easier to handle 😉 |
|
Changed it to use |
|
It looks like prettier-standard does not fix all its issues, which kinda defeats the point of prettier |
|
Superseded by #275. |
4 participants
Related to #262
with this the formatter runs on
npm test(in the root) and on any modified file (via pre-commit hook)