Conversation
| }) | ||
|
|
||
| test.skip('it builds', t => { | ||
| test.only('it builds', async t => { |
There was a problem hiding this comment.
Forgot to remove it, will fix later
| @@ -1,11 +1,12 @@ | |||
| { | |||
| "private": true, | |||
There was a problem hiding this comment.
Should I keep it?
There was a problem hiding this comment.
Yeah, the monorepo root package.json should be private. Only the packages it contains should be published, never the monorepo root 😉
| testHtml() | ||
| testCss() | ||
| testJs() | ||
| t.end() |
There was a problem hiding this comment.
Tests are failing because t.end() is not needed.
|
Thx for your PR, Vlad. Good ideas! I'd just like to move updating the dependencies and refactoring the ugly callback-based test into separate PRs. |
|
Merged with master, updated lerna to latest, bumped a few deps and fixed tests. We have to update certain deps in this PR because of the way lerna hoists them. For instance, if one package has "webpack@^3" and another has "webpack@^2", lerna will hoist "webpack@^3" to the root folder and won't install "webpack@^2" at all. This is very weird and I dislike such behaviour, yarn workspaces never do this. |
|
Can we merge it? It's blocking me from doing more awesome stuff! 🙃 |
|
I know that the |
|
Have been experimenting with yarn workspaces and Used oao instead of lerna, because lerna's "run script in all packages" output often is hardly readable. |
|
Sure, that would be my next steps after this PR. We should also consider |
|
Can barely tell the difference between But this PR is really hard to review... |
|
@andywer @vlad-zhukov We now use Yarn workspaces, so this PR can be closed. |
3 participants
I made a few changes we've discussed in #226, #231, #204
Closes #204
What have I done:
lernato 2.4.0 (Improve build #226 (comment))--hoistflag tolerna bootstrap(Try lerna hoisting #204) and ran it with the latestnpm@5.5.1(it's responsible for upgrading all deps and it's not possible to revert it, we have to useyarnif we want more predictable behaviour in this department)sample-appintoexamplesfolder (Fix validation error with default uglify options #231 (review))--parallelflag tolerna run test, it should be faster now (we haven't discussed it before but I find it interesting to try)sample-appThis is a WIP because I can't make tests pass locally due to a weird error in the
elmblock. Would be great if someone could help me with it because I've no experience withelm.P.S.: Sorry for a large PR, I can try to split it if you want.