Major refactoring: Callback & iterable support#273
Draft
Conversation
6f41e98 to
18968f9
Compare
This was referenced Jul 3, 2020
|
Thanks for the awesome library @andywer, I'm really enjoying using it so far. This PR looks really cool, I'd love to be able to use async iterables. Is this something your still working on? |
|
Hi, I was taking a look at one of the issues of the repo and trying to find info about the possibility of using callbacks and I was wondering Is this PR gonna happen? Thanks for the amazing work with threads.js <3 |
Owner
Author
|
@EmmanuelAAM Thanks for the kind words! I'm afraid this is on hold as there seemed to be limited interest and I currently don't have extra time to spend on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to expose callbacks function. Works main-to-worker as well as worker-to-main.
It's a major refactoring, using the callbacks to implement the existing
spawn()andexpose()APIs. Also introduces support to return iterables and async iterables.Closes #145. Closes #251.