Changes to compile on late avr-gcc and Arduino core #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple definition of default template arguments
Signed-off-by: Gionata Boccalini <gionata.boccalini@gmail.com>
with std::crlf. Modified class member (basic_serialbuf) to become a pointer: fixes the serial print bug, taken from https://github.com/maniacbug/StandardCplusplus
|
Thank you very much for this. I'll review it and get back to you. |
|
Any news on this one?? |
Repository owner
deleted a comment from
lowlevl
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some changes to the library and added the examples on the blog post, ready to be compiled and uploaded with a makefile.
The Serial write wasn't working properly, it has been fixed with code from https://github.com/maniacbug/StandardCplusplus.
The use of std::crlf is optional now, i.e. std::endl can be used the same way.
The library now compiles with avr-g++ version 6.3.0, using the original Arduino Core from https://github.com/arduino/Arduino, with new and delete opeartors.