Fix panic in checkAuth() if Gerrit is down #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously checkAuth() would fail if the socket we expected to find Gerrit running on didn't have anything listning. This would result in the connection be refused and no response being sent from GetAccount(). The checkAuth() function was always expecting some kind of response which in turn caused the panic.
|
@andygrunwald PTAL. This one is pretty simple, found it by accident while working on a project. I'll probably have one or two more changes coming for 0.5.2 so I plan to hold off on a release for a bit. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously checkAuth() would fail if the socket
we expected to find Gerrit running on didn't
have anything listning. This would result in
the connection be refused and no response being
sent from GetAccount().
The checkAuth() function was always expecting
some kind of response which in turn caused the
panic.