Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewClient() can't handle credentials containing characters such as / #39

Merged
merged 3 commits into from
Sep 5, 2017
Merged

NewClient() can't handle credentials containing characters such as / #39

merged 3 commits into from
Sep 5, 2017

Commits on Sep 4, 2017

  1. fix NewClient() url parsing for passwords containing / or other url c… 

    …haracters

Depending on the contents of the username and password the default
url.Parse may not work. The below is an example URL that
would end up being parsed incorrectly with url.Parse:
  http://admin:ZOSOKjgV/kgEkN0bzPJp+oGeJLqpXykqWFJpon/Ckg@localhost:38607

So instead of depending on url.Parse we'll try using a regular expression
first to match a specific pattern instead. This won't be 100% reliable
in all cases which is why we fall back onto using url.Parse anyway.
    @opalmer
    opalmer committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    ba033b0 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @opalmer
    opalmer committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    52a27d6 View commit details
    Browse the repository at this point in the history

  3. lint fix

    @opalmer
    opalmer committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    28a9265 View commit details
    Browse the repository at this point in the history