Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Static Analysis and Fix Bugs #38

Merged
merged 18 commits into from
Jun 23, 2017
Merged

Implement Static Analysis and Fix Bugs #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5578108
run gofmt
opalmer Jun 18, 2017
15763b3
adding Makefile and gometalinter
opalmer Jun 18, 2017
ead06e9
fix comments above errors in authentication.go
opalmer Jun 18, 2017
02a845f
add missing comment above
opalmer Jun 18, 2017
2b303e0
ignore shadow issue (no scoping problems)
opalmer Jun 18, 2017
1c8978e
fixing golint issues
opalmer Jun 18, 2017
d670484
more vet issues
opalmer Jun 18, 2017
9717f34
ignore warning from gas linter
opalmer Jun 18, 2017
f6881fa
adding missing error checks
opalmer Jun 18, 2017
a637fa1
adding missing input paramter to NewRequest
opalmer Jun 18, 2017
7df1d43
fixing gometalinter config
opalmer Jun 18, 2017
9306f1a
fixing doc string, removing unused param
opalmer Jun 18, 2017
33c81a2
run makefile on travis
opalmer Jun 18, 2017
0f5d7ae
update changelog
opalmer Jun 18, 2017
e114f21
add deps target
opalmer Jun 18, 2017
84dffa1
fix style
opalmer Jun 18, 2017
410d4f4
merge master -> branch
opalmer Jun 18, 2017
709c69f
remove go 1.5 from .travis.yml
opalmer Jun 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding missing input paramter to NewRequest
  • Loading branch information
@opalmer
opalmer committed Jun 18, 2017
commit a637fa183c4ace1b23038193a6d78bf43358cd3a
2 changes: 1 addition & 1 deletion changes_revision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ func (s *ChangesService) SetReviewed(changeID, revisionID, fileID string) (*Resp
func (s *ChangesService) CherryPickRevision(changeID, revisionID string, input *CherryPickInput) (*ChangeInfo, *Response, error) {
u := fmt.Sprintf("changes/%s/revisions/%s/cherrypick", changeID, revisionID)

req, err := s.client.NewRequest("POST", u, nil)
req, err := s.client.NewRequest("POST", u, input)
if err != nil {
return nil, nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion groups_include.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func (s *GroupsService) IncludeGroup(groupID, includeGroupID string) (*GroupInfo
func (s *GroupsService) IncludeGroups(groupID string, input *GroupsInput) (*[]GroupInfo, *Response, error) {
u := fmt.Sprintf("groups/%s/groups", groupID)

req, err := s.client.NewRequest("POST", u, nil)
req, err := s.client.NewRequest("POST", u, input)
if err != nil {
return nil, nil, err
}
Expand Down