Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Digest Authentication #5

Closed
chnrxn opened this issue Jan 30, 2016 · 3 comments · Fixed by #8
Closed

Implement Digest Authentication #5

chnrxn opened this issue Jan 30, 2016 · 3 comments · Fixed by #8

Comments

@chnrxn
Copy link

chnrxn commented Jan 30, 2016

Is there a plan for implementing Digest authentication?
@andygrunwald
Copy link
Owner

Thanks for your question @chnrxn.
I want to see Digest auth in go-gerrit, yes. There is a need for it.
A correct / detailed plan is not existing, because i implement these features mostly if i need them myself.
I only need to find time for it, but will be happy to support you or another contributer who is interested in implementing digest auth.

Is this an option for you?

@andygrunwald
Copy link
Owner

A side note for a future me: This can be helpful https://github.com/mattbaird/http-digest-auth-client

opalmer added a commit to opalmer/go-gerrit that referenced this issue Jul 15, 2016
@opalmer
add support for digest based authentication
1d5fb72 
This should resolve andygrunwald#5
@opalmer opalmer mentioned this issue Jul 15, 2016
Merged
@andygrunwald
Copy link
Owner

@chnrxn Digest auth is now supported. Have a look at the README for a few examples :)
Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for digest based authentication opalmer/go-gerrit
2 participants
@andygrunwald @chnrxn