This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Use correct width for weekday names #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your changes conflict with @caridy's recent improvements, could you rebase and update both your pull requests please? Thanks :) |
kate2753
force-pushed
the
use-correct-widths
branch
from
754bd76
to
d67923a
Compare
|
@andyearnshaw I've updated both of the pull requests. Unit tests look good in node (all of them pass). I see that saucelabs refused connection for some of the browsers, so Travis build failed overall |
andyearnshaw
added a commit
that referenced
this pull request
May 19, 2015
Use correct width for weekday names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #92
This will hardly have any impact on size of locale data files. In most cases locale data files will become a bit smaller because
narrowweekdays names tend to be smaller thanshortones.