Skip to content

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Nov 19, 2023

back_jump_prob*.py: Return normalization factors

Type of change

  • Change of core package.
  • Change of scripts.
  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed changes

  • Script scripts/discretization/back_jump_prob.py: Add another column to the output file containing the normalization factors used to calculate the back-jump probabilities.
  • Script scripts/discretization/back_jump_prob_discrete.py: Add a new command-line option --norm-out that allows the user to create another output file that contains the normalization factors used to calculate the back-jump probabilities.

PR checklist

  • I followed the guidelines in the Developer's guide.
  • New/changed code is properly tested.
  • New/changed code is properly documented.
  • The CI workflow is passing.

Add another column to the output file of the script
`scripts/discretization/back_jump_prob.py` that contains the
normalization factors used to calculate the back-jump probabilities.

Multiplying the back-jump probabilities with the normalization factors
yields the total number of back jumps.
Add a new command-line option `--norm-out` to the script
`scripts/discretization/back_jump_prob_discrete.py` that allows the user
to create another output file that contains the normalization factors
used to calculate the back-jump probabilities.

Multiplying the back-jump probabilities with the normalization factors
yields the total number of back jumps.
@github-actions github-actions bot added enhancement New feature or request minor Change that results in a new minor version labels Nov 19, 2023
@andthum andthum merged commit 5cf8bbf into main Nov 19, 2023
@andthum andthum deleted the feat/scripts/discretization/back-jump-probability branch November 19, 2023 17:38
andthum added a commit to andthum/hpc_submit_scripts that referenced this pull request Nov 19, 2023
Use the new command-line option of the MDTool script
`back_jump_prob_discrete.py`, `--norm-out`, to receive an output file
with the normalization factors used to calculate the back-jump
probabilities (see andthum/mdtools#201).
andthum added a commit to andthum/hpc_submit_scripts that referenced this pull request Nov 19, 2023
…actors

Use the new command-line option of the MDTool script
`back_jump_prob_discrete.py`, `--norm-out`, to receive an output file
with the normalization factors used to calculate the back-jump
probabilities (see andthum/mdtools#201).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Change that results in a new minor version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants