[submit_mdt_analyses_lintf2_ether.py]: Additional --scripts Options
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the additional `--script` options
* 11.3: All "normal" bulk renewal event lifetimes.
* 11.4: All spatially discretized renewal event lifetimes.
This allows users to submit "normal" bulk renewal event lifetimes and
spatially discretized renewal event lifetimes separately which was not
possible before.
Additionally, remove the analysis scripts
`renewal_events_Li-ether_state_lifetime.sh` and
`renewal_events_Li-NTf2_state_lifetime.sh` from the list of scripts that
require the spatially discretized
`${settings}_${system}_discrete-z_Li_dtrj.npy` trajectory. The scripts
were listed wrongly there.
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[submit_mdt_analyses_lintf2_ether.py]: Additional
--scriptsOptionsType of Change
Proposed Changes
Add the additional
--scriptoptionsThis allows users to submit "normal" bulk renewal event lifetimes and spatially discretized renewal event lifetimes separately which was not possible before.
Additionally, remove the analysis scripts
renewal_events_Li-ether_state_lifetime.shandrenewal_events_Li-NTf2_state_lifetime.shfrom the list of scripts that require the spatially discretized${settings}_${system}_discrete-z_Li_dtrj.npytrajectory. The scripts were listed wrongly there.PR Checklist