Skip to content

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Aug 25, 2022

[gmx_mdrun.sh]: Exit When gmx mdrun Fails

Type of Change

  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Motivation and Context

By now, gmx_mdrun.sh is not terminated when the call of gmx mdrun fails. The reason behind this was that the Slurm job script should not be terminated when gmx mdrun was terminated by the INT signal to allow for cleanup steps. However, the Slurm job script should be terminated if gmx mdrun indeed fails (without having received the INT signal).

Proposed Changes

Check the exit code of the gmx mdrun command and exit the Slurm job script if the exit code is not 0 (successful mdrun) and not 1 (mdrun terminated by INT signal).

PR Checklist

  • I followed the guidelines in the Developer's Guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • New/changed features are tracked in CHANGELOG.rst.
  • The CI workflow is passing.

Check the exit code of the `gmx mdrun` command and exit the Slurm job
script if the exit code is not 0 (successful mdrun) and not 1
(mdrun terminated by INT signal).
@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version labels Aug 25, 2022
@andthum andthum merged commit e823e05 into main Aug 25, 2022
@andthum andthum deleted the fix/gmx-mdrun/exit-codes branch August 25, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull requests that fix a bug patch Change that results in a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants