Skip to content

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Nov 22, 2023

Fix --discretize Option of Analysis Submit Scripts

Type of Change

  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed Changes

  • Python submit scripts submit_gmx_analyses_lintf2_ether.py and submit_mdt_analyses_lintf2_ether.py: Fix the function _submit_discretized: Reset the submit command after each loop instead of appending it.
  • Python submit script submit_mdt_analyses_lintf2_ether.py: Convert the box length that is read from the .gro file from nanometers to Angstrom.

PR Checklist

  • I followed the guidelines in the Developer's Guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • The CI workflow is passing.

@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version labels Nov 22, 2023
@andthum andthum force-pushed the fix/lintf2_ether/analysis-submit-scripts branch 3 times, most recently from 233feca to 5c02178 Compare November 23, 2023 10:32
* Fix the function `_submit_discretized`: Reset the submit command after
  each loop instead of appending it.
* Convert the box length that is read from the .gro file from nm to
  Angstrom.
Fix the function `_submit_discretized`: Reset the submit command after
each loop instead of appending it.
* Increase memory limit
* Decrease time limit
* Decrease number of CPUs
@andthum andthum force-pushed the fix/lintf2_ether/analysis-submit-scripts branch from 5c02178 to 46d5163 Compare November 25, 2023 14:15
@andthum andthum merged commit 4c2c659 into main Nov 25, 2023
@andthum andthum deleted the fix/lintf2_ether/analysis-submit-scripts branch November 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull requests that fix a bug patch Change that results in a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants