Skip to content

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Nov 16, 2023

Refactor Scripts That Analyze a Slab in xy Plane

Type of Change

  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed Changes

  • Slurm job scripts axial_hex_dist_*nn_*.sh, contact_hist_slab-z_Li-*.sh, discrete-hex_*.sh, densmap-z_*.sh and *rdf_slab-z_*.sh: During cleanup, change the name of the Slurm output file to contain the slab size.
  • Slurm job script axial_hex_dist_1nn_OBT.sh: Fix Typo in Analysis Name
  • Slurm job scripts axial_hex_dist_*nn_*.sh: Decrease Time and Memory Limit
  • Slurm job scripts contact_hist_slab-z_Li-*.sh: Decrease Memory Limit
  • Slurm job scripts discrete-hex_*.sh: Decrease Time Limit

PR Checklist

  • I followed the guidelines in the Developer's Guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • The CI workflow is passing.

During cleanup, change the name of the Slurm output file to contain the
slab size.
During cleanup, change the name of the Slurm output file to contain the
slab size.
During cleanup, change the name of the Slurm output file to contain the
slab size.
During cleanup, change the name of the Slurm output file to contain the
slab size.
During cleanup, change the name of the Slurm output file to contain the
slab size.
@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version refactoring Code refactoring labels Nov 16, 2023
@andthum andthum merged commit 745a861 into main Nov 16, 2023
@andthum andthum deleted the ref/analysis/lintf2-ether/slab-z branch November 16, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull requests that fix a bug patch Change that results in a new patch version refactoring Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants