Skip to content

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Nov 15, 2023

Fix Path to MDTools Script discrete_hex.py

Type of Change

  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed Changes

  • Slurm job scripts discrete_hex_*.sh:
    • Fix the path to the MDTools script discrete_hex.py from /scripts/structure/discrete_hex.py to scripts/discretization/discrete_hex
    • Fix the clean up step
    • Update Requested Resources
  • Bash script .cleanup_mdt_analyses.sh: Fix Typo in Cleanup of discrete-hex
  • Slurm job scripts axial_hex_dist_*nn_*.sh: Fix Cleanup and Update Requested Resources
  • Slurm job scripts contact_hist_slab-z_Li-*.sh: Fix Cleanup and Update Requested Resources
  • Slurm job scripts densmap-z_*.sh: Fix Cleanup and Update Requested Resources
  • Slurm job scripts *rdf_slab-z_*.sh: Fix Cleanup

PR Checklist

  • I followed the guidelines in the Developer's Guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • The CI workflow is passing.

Fix the path to the MDTools script `discrete_hex.py` from
`/scripts/structure/discrete_hex.py` to
`scripts/discretization/discrete_hex`.
@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version labels Nov 15, 2023
* Fix the clean up step which didn't moved the Slurm output file to the
  analysis directory because of a wrong file pattern.
* Set the time limit of all Slurm jobs to one day.
* Adjust the memory limit for `discrete-hex_OBT.sh` and
  `siscrete-hex_OE.sh`.
* Fix the clean up step which didn't moved the Slurm output file to the
  analysis directory because of a wrong file pattern.
* Set the time limit of all Slurm jobs to one day.
…rces

* Fix the clean up step which didn't moved the Slurm output file to the
  analysis directory because of a wrong file pattern.
* Set the time limit of all Slurm jobs to one day.
* Fix the clean up step which didn't moved the Slurm output file to the
  analysis directory because of a wrong file pattern.
* Set the time limit of all Slurm jobs to one day.
Fix the clean up step which didn't moved the Slurm output file to the
analysis directory because of a wrong file pattern.
@andthum andthum merged commit c0d0830 into main Nov 15, 2023
@andthum andthum deleted the fix/analysis/lintf2-ether/mdt/discrete-hex branch November 15, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull requests that fix a bug patch Change that results in a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants