Feat: Vdf Mint ADO #830

mdjakovic0920 · 2025-03-07T11:51:40Z

Motivation

Let’s think about it in context of an NFT minting function.
We put a VDF ADO in front of the mint function and then someone can only mint one every 5 minutes.
This PR implements this VDF conception into the ADO.

Implementation

#[andr_instantiate]
#[cw_serde]
pub struct InstantiateMsg {
    pub cw721_address: AndrAddr,
    pub actors: Option<Vec<AndrAddr>>,
    pub mint_cooldown_minutes: Option<Uint64>,
}

#[andr_exec]
#[cw_serde]
pub enum ExecuteMsg {
    #[attrs(restricted, nonpayable)]
    AddActors { actors: Vec<AndrAddr> },
    #[attrs(nonpayable)]
    VdfMint { token_id: String, owner: AndrAddr },
}

#[andr_query]
#[cw_serde]
#[derive(QueryResponses)]
pub enum QueryMsg {
    #[returns(GetActorsResponse)]
    GetActors {},
    #[returns(GetMintCooldownMinutesResponse)]
    GetMintCooldownMinutes {},
    #[returns(GetLastMintTimestampSecondsResponse)]
    GetLastMintTimestampSeconds {},
}

Testing

Unit test cases are added. (will add e2e tests with other ADOs(like Cw721))

Version Changes

Vdf Mint ADO Version: "0.1.0-b.1"

Checklist

Versions bumped correctly and documented
Changelog entry added or label applied

…-core into mdjakovic/vdf

coderabbitai · 2025-03-07T11:51:48Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

contracts/modules/andromeda-vdf-mint/src/contract.rs

joemonem · 2025-03-14T12:51:51Z

packages/andromeda-modules/src/vdf_mint.rs

+#[cw_serde]
+pub enum ExecuteMsg {
+    #[attrs(restricted, nonpayable)]
+    AddActors { actors: Vec<AndrAddr> },


Users should also have the option to remove actors

Added remove_actors function

…-core into mdjakovic/vdf

joemonem · 2025-03-31T07:52:24Z

Can't we achieve this by extending the functionality of our Permissioning system? For example we already can limit the number of uses for a given action.
We could add another option of time intervals for each action.
What do you think?

mdjakovic0920 · 2025-03-31T11:31:34Z

Can't we achieve this by extending the functionality of our Permissioning system? For example we already can limit the number of uses for a given action. We could add another option of time intervals for each action. What do you think?

Of course, it would be nice if we could extend the Permissioning system to add this functionality.

cowboy0015 · 2025-06-26T16:23:01Z

packages/andromeda-modules/src/vdf_mint.rs

+    RemoveActors { actors: Vec<AndrAddr> },
+    #[attrs(nonpayable)]
+    VdfMint { token_id: String, owner: AndrAddr },
+}


MINT_COOLDOWN_MINUTES should be customized as well.

cowboy0015 · 2025-06-26T16:25:05Z

contracts/modules/andromeda-vdf-mint/src/contract.rs

+        msg: to_json_binary(&andromeda_non_fungible_tokens::cw721::ExecuteMsg::Mint {
+            token_id,
+            owner: owner.get_raw_address(&ctx.deps.as_ref())?.to_string(),
+            token_uri: None, // Add a URI if needed


Tokens minted via VdfMint will always have no token_uri. It should be passed by the VdfMint message

cowboy0015 · 2025-06-26T16:33:23Z

contracts/modules/andromeda-vdf-mint/src/contract.rs

+    token_id: String,
+    owner: AndrAddr,
+) -> Result<Response, ContractError> {
+    let cw721_address = CW721_ADDRESS.load(ctx.deps.storage)?;


Ensure info.sender has mint permission before proceeding. Unless anyone will be able to mint via VdfMint

mdjakovic0920 added 2 commits March 7, 2025 11:46

feat: vdf mint ADO

8299969

Merge branch 'main' of https://github.com/andromedaprotocol/andromeda…

2ce8680

…-core into mdjakovic/vdf

github-actions bot added the packages/std Includes changes to the Standard crate label Mar 7, 2025

update CHANGELOG.md

3f3539e

mdjakovic0920 removed the packages/std Includes changes to the Standard crate label Mar 7, 2025

fix: linting error

4e95599

github-actions bot added the packages/std Includes changes to the Standard crate label Mar 7, 2025

fix: linting error

1a15459

joemonem reviewed Mar 14, 2025

View reviewed changes

contracts/modules/andromeda-vdf-mint/src/contract.rs Outdated Show resolved Hide resolved

joemonem reviewed Mar 14, 2025

View reviewed changes

contracts/modules/andromeda-vdf-mint/src/contract.rs Show resolved Hide resolved

joemonem reviewed Mar 14, 2025

View reviewed changes

contracts/modules/andromeda-vdf-mint/src/contract.rs Show resolved Hide resolved

joemonem reviewed Mar 14, 2025

View reviewed changes

mdjakovic0920 added 3 commits March 19, 2025 06:36

feat: remove actors function and simplified some functions

94887aa

Merge branch 'main' of https://github.com/andromedaprotocol/andromeda…

f63fe13

…-core into mdjakovic/vdf

fix: reference

4e568d4

joemonem mentioned this pull request Apr 7, 2025

feat: Permissioning Frequency #855

Open

2 tasks

cowboy0015 requested changes Jun 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat: Vdf Mint ADO #830

Feat: Vdf Mint ADO #830

Uh oh!

mdjakovic0920 commented Mar 7, 2025

Uh oh!

coderabbitai bot commented Mar 7, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joemonem Mar 14, 2025

Uh oh!

mdjakovic0920 Mar 19, 2025

Uh oh!

joemonem commented Mar 31, 2025

Uh oh!

mdjakovic0920 commented Mar 31, 2025

Uh oh!

cowboy0015 Jun 26, 2025

Uh oh!

cowboy0015 Jun 26, 2025

Uh oh!

cowboy0015 Jun 26, 2025

Uh oh!

Uh oh!

Feat: Vdf Mint ADO #830

Are you sure you want to change the base?

Feat: Vdf Mint ADO #830

Uh oh!

Conversation

mdjakovic0920 commented Mar 7, 2025

Motivation

Implementation

Testing

Version Changes

Checklist

Uh oh!

coderabbitai bot commented Mar 7, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joemonem Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

mdjakovic0920 Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

joemonem commented Mar 31, 2025

Uh oh!

mdjakovic0920 commented Mar 31, 2025

Uh oh!

cowboy0015 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

cowboy0015 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

cowboy0015 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)