Skip to content

Trust controllers from apps in current UID #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

Trust controllers from apps in current UID #2555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions libraries/session/src/main/java/androidx/media3/session/MediaSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,9 +622,18 @@ public int getMaxCommandsForMediaItems() {
}

/**
* Returns if the controller has been granted {@code android.permission.MEDIA_CONTENT_CONTROL}
* or has an enabled notification listener so it can be trusted to accept connection and
* incoming command requests.
* Returns whether one or more of the following is true:
*
* <ul>
* <li>the controller's app UID is in the same UID as the current process
* <li>the controller's app UID is the system UID
* <li>the controller has been granted {@code android.permission.MEDIA_CONTENT_CONTROL}
* <li>the controller has been granted {@code android.permission.STATUS_BAR_SERVICE}
* <li>the controller has an enabled notification listener
* </ul>
*
* to determine if the controller can be trusted to accept connection and incoming command
* requests.
*/
@UnstableApi
public boolean isTrusted() {
Expand Down
1 change: 1 addition & 0 deletions libraries/session/src/main/java/androidx/media3/session/legacy/MediaSessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ public boolean isTrustedForMediaControl(MediaSessionManager.RemoteUserInfoImpl u
return isPermissionGranted(userInfo, PERMISSION_STATUS_BAR_SERVICE)
|| isPermissionGranted(userInfo, PERMISSION_MEDIA_CONTENT_CONTROL)
|| userInfo.getUid() == Process.SYSTEM_UID
|| userInfo.getUid() == Process.myUid()
|| isEnabledNotificationListener(userInfo);
}

Expand Down