Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve discontinuities when seeking into fragmented AC-4 audio #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hcgil
Copy link

@hcgil hcgil commented Feb 22, 2023

Related to google/ExoPlayer#11000

Proof of concept for resolving discontinuities in FMP4 AC-4 playback.

The underlying cause on our end appears to come from the fact that we can't anticipate sync frames when committing them to our sample queue. Once we reach the end of our first fragment, we begin committing samples to our sample queue, even if suitable sync frames are available in later fragments.

For this PR, we would have some sort of intermediate structure to retain samples before committing them, in the event that our format does not guarantee that every frame is a key frame. When we encounter a key frame, we empty the contents of this structure, as we can begin playback from that key frame instead. When we pass our start time, we commit any samples in the intermediate structure to our sample queue, allowing us to play from the nearest key frame.

@google-cla
Copy link

google-cla bot commented Feb 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@icbaker icbaker self-assigned this Feb 22, 2023
@icbaker
Copy link
Collaborator

icbaker commented Feb 22, 2023

Please can you sign the CLA, then we can take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants