-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player view to show post-processed resolution instead of the input one #1025
Conversation
Found |
We recently changed the way of size notification and decided to temporarily disable the size notification to the app, in dcae49a So unfortunately this fix won't work before we bring back the size notification. |
0e5a962
to
36c7b4e
Compare
To clarify on this PR -
|
@claincly I think this PR would be useful for at least two use cases:
|
Sounds good, one thing related to pushing the PR: Would it be possible to open a new PR from an individual-owned fork? We can't push changes to organization-owned forks like this one unless we have collaborator access. If that's not possible then we can still merge this PR but it will result in an 'evil' merge. See more info here: https://github.com/androidx/media/blob/release/CONTRIBUTING.md#push-access-to-pr-branches |
@claincly no prob, I've given you write permission so you can commit into our originating branch |
…changes from video effects
36c7b4e
to
0cdae9a
Compare
PiperOrigin-RevId: 612485043 (cherry picked from commit bbdaf2b)
PiperOrigin-RevId: 612485043 (cherry picked from commit bbdaf2b)
Problem
If a video effect is applied to the video, or an "enhancement" such as LCEVC, is applied, the on screen player view debug text still shows the "input" resolution and pixel aspect ratio and not the one after post-processing. This can be easily reproduced with effects such as
Crop
orScaleAndRotateTransformation
which change the output resolution.Root cause
The resolution and pixel aspect ratio shown are taken from the input Format object, which is a property of the stream and not of the video decoding and post processing applied.
Proposed solution
Take with, height and pixel aspect ratio from the player's VideoSize, which does get updated in case of post-processing.