Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom extras in MediaMetadata not getting populated in MediaMetadataCompat #802

Closed
1 task done
zzmgoing opened this issue Nov 9, 2023 · 1 comment
Closed
1 task done

Custom extras in MediaMetadata not getting populated in MediaMetadataCompat #802

zzmgoing opened this issue Nov 9, 2023 · 1 comment
Assignees
@rohitjoins
Labels
bug needs triage

Comments

@zzmgoing
Copy link

zzmgoing commented Nov 9, 2023

Version

Media3 1.1.1

More version details

No response

Devices that reproduce the issue

All

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

  1. client use media3
    val mediaMetadata = MediaMetadata.Builder().setExtras(bundleOf("my_custom_key" to "my value")).build()
    val mediaItem = MediaItem.Builder().setMediaMetadata(mediaMetadata).build()
  2. sdk use media
    android.media.session.MediaController#registerCallback(android.media.session.MediaController.Callback)
    android.media.session.MediaController.Callback#onMetadataChanged
    MediaMetadataCompat does not contain "my_custom_key"
  3. i found
    androidx.media3.session.MediaUtils#convertToMediaMetadataCompat
    MediaMetadata extras are not processed

Expected result

I saw this issue has been solved 756, but my problem is exactly the opposite of this one.

Actual result

MediaMetadataCompat does not contain "my_custom_key" in onMetadataChanged method

Media

Not applicable

Bug Report
@rohitjoins rohitjoins self-assigned this Nov 13, 2023
copybara-service bot pushed a commit that referenced this issue Nov 17, 2023
@rohitjoins @copybara-github
Populate MediaMetadata.extras to MediaMetadataCompat
6df2408 
Ensures backward compatibility.

Issue: #802
PiperOrigin-RevId: 583425114
@rohitjoins
Copy link
Contributor

Fix was submitted to the main branch 6df2408.

copybara-service bot pushed a commit to google/ExoPlayer that referenced this issue Nov 17, 2023
@rohitjoins @copybara-github
Populate MediaMetadata.extras to MediaMetadataCompat
4bbd2a4 
Ensures backward compatibility.

Issue: androidx/media#802
PiperOrigin-RevId: 583425114
microkatz pushed a commit that referenced this issue Jan 11, 2024
@rohitjoins @microkatz
Populate MediaMetadata.extras to MediaMetadataCompat
aab1c9a 
Ensures backward compatibility.

Issue: #802
PiperOrigin-RevId: 583425114
(cherry picked from commit 6df2408)
@androidx androidx locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rohitjoins rohitjoins

Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zzmgoing @rohitjoins