Retrieve results successfully when merged_results.xml is missing #71
Conversation
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Outdated
Show resolved
Hide resolved
| return emptyList() | ||
| } | ||
| val deviceId = byFullDeviceId.values.first().deviceRun.deviceId | ||
| val mergedResults = byFullDeviceId.values.first().xmlResults.first() |
There was a problem hiding this comment.
this is not merged anymore so we shouldn't call it mergedResults.
why do we return the first one instead of all available?
There was a problem hiding this comment.
Yeah, these are not mergedResults. But there should only be 1 result present in the byFullDeviceId map. So, using the xmlResult file here from that result would essentially have the same content as merged results file.
There was a problem hiding this comment.
then we shouldn't call the variable mergedResults.
Furthermore, i think it is more consistent for this to be:
if merged results exists, return it
otherwise, return all others.
byDeviceId.values.map { TestRunResult(...) }
There was a problem hiding this comment.
Made mergedResults nullable so that when mreged_results.xml file is not present, we can set it to null and incorporated rest of your feedback. Please review.
…RunnerServiceImpl.kt Co-authored-by: Yigit Boyar <yboyar@google.com>
2 participants
Retrieve results successfully when merged_results.xml is missing