Create testMatrix to rerun failed tests in FTL #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnakade
changed the title
rnakade
requested review from
liutikas and
yigit
and removed request for
yigit
yigit
suggested changes
Aug 25, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/FirebaseTestLabController.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestMatrixStore.kt
Outdated
Show resolved
Hide resolved
Added. Ready for review again. |
yigit
suggested changes
Aug 28, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestMatrixStore.kt
Outdated
Show resolved
Hide resolved
rnakade
commented
Aug 29, 2023
| flakyTestAttempts: Int = 2 | ||
| ): TestMatrix { | ||
|
|
||
| val testApk = ApkInfo( |
There was a problem hiding this comment.
Still figuring out how to get ApkInfo for testapk and appapk from ftlTestMatrix
yigit
reviewed
Aug 29, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestMatrixStore.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestMatrixStore.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestMatrixStore.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/test/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImplTest.kt
Show resolved
Hide resolved
|
Addressed all the feedback I think. Please review! |
yigit
approved these changes
Aug 31, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestMatrixStore.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create testMatrix to rerun failed tests in FTL