Rn/upload screenshots #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutikas
approved these changes
May 8, 2023
liutikas
reviewed
May 8, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerService.kt
Outdated
Show resolved
Hide resolved
yigit
suggested changes
May 8, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerService.kt
Outdated
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Outdated
Show resolved
Hide resolved
yigit
reviewed
May 8, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Outdated
Show resolved
Hide resolved
yigit
reviewed
May 8, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Show resolved
Hide resolved
yigit
reviewed
May 9, 2023
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerService.kt
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerService.kt
Show resolved
Hide resolved
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Show resolved
Hide resolved
| val testName = testNames.keys.find { testName -> | ||
| visitor.fileName.startsWith(testName) | ||
| } | ||
| val testIdentifier = testNames[testName] |
There was a problem hiding this comment.
does this work fine if testName is null?
There was a problem hiding this comment.
Yes, checking if testIdentifier is null in the next line. So, I believe this should be ok.
There was a problem hiding this comment.
i was wondering what happens with testNames[null].
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-map/get.html
get is declared to receive K which is nonNull here, idk the implementation but we are passing a nullable value to a non-null key.. not sure why compiler doesn't complain about this :/. do we have a test that covers testName being null here?
There was a problem hiding this comment.
Yeah, there are tests which basically cover this scenario. But, I have also more files to make sure this scenario is fully covered.
Here's the output for different files:
filename = redfin-30-en-portrait-test_results_merged.xml
testName = null
testIdentifier = null
filename = logcat
testName = null
testIdentifier = null
filename = test_result_1.xml
testName = null
testIdentifier = null
filename = test_result_2.xml
testName = null
testIdentifier = null
filename = 0000_logcat
testName = null
testIdentifier = null
filename = 0001_logcat
testName = null
testIdentifier = null
filename = class1_name1_emulator_actual.png
testName = class1_name1
testIdentifier = TestIdentifier(className=class1, name=name1, runNumber=0)
filename = class1_name1_emulator_diff.png
testName = class1_name1
testIdentifier = TestIdentifier(className=class1, name=name1, runNumber=0)
filename = class1_name1_emulator_expected.png
testName = class1_name1
testIdentifier = TestIdentifier(className=class1, name=name1, runNumber=0)
filename = class1_name1_emulator_goldResult.textproto
testName = class1_name1
testIdentifier = TestIdentifier(className=class1, name=name1, runNumber=0)
filename = class5_name5_emulator_goldResult.textproto
testName = null
testIdentifier = null
filename = redfin-30-en-portrait-test_results_merged.xml
testName = null
testIdentifier = null
filename = logcat
testName = null
testIdentifier = null
filename = test_result_1.xml
testName = null
testIdentifier = null
filename = test_result_2.xml
testName = null
testIdentifier = null
filename = 0000_logcat
testName = null
testIdentifier = null
filename = 0001_logcat
testName = null
testIdentifier = null
filename = class1_name1_emulator_actual.png
testName = null
testIdentifier = null
filename = class1_name1_emulator_diff.png
testName = null
testIdentifier = null
filename = class1_name1_emulator_expected.png
testName = null
testIdentifier = null
filename = class1_name1_emulator_goldResult.textproto
testName = null
testIdentifier = null
filename = class5_name5_emulator_goldResult.textproto
testName = null
testIdentifier = null
filename = redfin-30-en-portrait-test_results_merged.xml
testName = null
testIdentifier = null
filename = logcat
testName = null
testIdentifier = null
filename = test_result_1.xml
testName = null
testIdentifier = null
filename = test_result_2.xml
testName = null
testIdentifier = null
filename = 0000_logcat
testName = null
testIdentifier = null
filename = 0001_logcat
testName = null
testIdentifier = null
filename = class1_name1_emulator_actual.png
testName = null
testIdentifier = null
filename = class1_name1_emulator_diff.png
testName = null
testIdentifier = null
filename = class1_name1_emulator_expected.png
testName = null
testIdentifier = null
filename = class1_name1_emulator_goldResult.textproto
testName = null
testIdentifier = null
filename = class5_name5_emulator_goldResult.textproto
testName = null
testIdentifier = null
AndroidXCI/lib/src/main/kotlin/dev/androidx/ci/testRunner/TestRunnerServiceImpl.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload screenshot files to ants.