Skip to content

Conversation

@amyZepp
Copy link
Contributor

@amyZepp amyZepp commented Dec 12, 2025

Updating Hello Android XR to latest Jetpack XR libraries

@gemini-code-assist
Copy link

Summary of Changes

Hello @amyZepp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on bringing the 'Hello Android XR' sample application up-to-date with the latest Jetpack XR libraries. This involves significant adjustments to how 3D model materials are defined and applied, reflecting API evolution within the XR framework. Beyond the core XR updates, the change also includes general dependency version bumps across the project and a minor refinement to a UI icon.

Highlights

  • Jetpack XR Library Updates: The project has been updated to the latest versions of Jetpack XR libraries, including arcore, compose, and scenecore, reflecting recent API changes.
  • 3D Model Material Handling Refactor: The BugdroidModel component was refactored to align with new XR library APIs for material creation and property setting, specifically for KhronosPbrMaterial.
  • Search Icon Implementation Change: The search icon in the SearchBar component was changed from using Icons.Filled.Search to a custom XML vector drawable (search_24px.xml).
  • Ambient Occlusion UI Removal: The user interface slider for adjusting ambient occlusion material properties was removed from BugdroidSliderControls.kt.
  • Dependency Version Bumps: Numerous other dependencies in gradle/libs.versions.toml have been updated to their latest versions, including Android Gradle Plugin, Kotlin, Compose BOM, and Material.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to use the latest Jetpack XR libraries. The dependency versions are updated and the code is adapted to the new APIs. The changes are generally good, but I've found a couple of issues in BugdroidModel.kt regarding the use of LaunchedEffect for setting material properties. One is a redundant call, and the other is a missing key that could lead to material properties not being applied correctly. My review includes suggestions to fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants