Resolve warnings in the Wakelock code snippets #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting code warnings in Android Studio, made some minor changes to resolve them: * used WakeLock.acquire(timeout) instead of acquire() * removed the redundant qualifier for POWER_SERVICE Once this PR is approved, I'll set up a corresponding docs CL to update the description to explain the acquire() parameter.
AliceYuan
approved these changes
Sep 5, 2025
misc/src/main/java/com/example/snippets/backgroundwork/WakeLockSnippetsJava.java
Outdated
Show resolved
Hide resolved
misc/src/main/java/com/example/snippets/backgroundwork/WakeLockSnippetsJava.java
Outdated
Show resolved
Hide resolved
… (wlTimeout -> WAKELOCK_TIMEOUT)
|
Made Alice's suggested changes. Alice, I've also sent you a CL to update the DAC documentation -- when you approve that I'll submit it and merge this PR. |
breanatate
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting code warnings in Android Studio, made some minor changes to resolve them:
WakeLock.acquire(timeout)instead ofacquire()POWER_SERVICEOnce this PR is approved, I'll set up a corresponding docs CL to update the description to explain the acquire() parameter.