Skip to content

Conversation

@hrach
Copy link

@hrach hrach commented Jun 7, 2023

This fixes the layout and makes the example fit the description:

The child composables are constrained by the Layout constraints (without the minHeight constraints), and they're placed based on the yPosition of the previous composable.

@simona-anomis
Copy link
Contributor

@hrach thanks for your PR. Could you please provide more info why you think this is needed? Since it's a simple code snippet, we just want the incoming parent constraints to be used as they are in this case

@hrach
Copy link
Author

hrach commented Jun 13, 2023

@simona-anomis

we just want the incoming parent constraints to be used as they are in this case

For containers, it is hardly wanted to impose incoming constraints on its children. "normal" Column/Row does not allow this at all, Box allows this after setting propagateMinConstraints=true.

What's more, as cited, the text mentions it ("without the minHeight constraints") but doesn't do it, which may mislead the reader even more.

@simona-anomis
Copy link
Contributor

@hrach ah I see. My interpretation was that, since it's a simple code snippet, "without the minHeight constraints" means we won't change any constraints, not even minHeight. But your interpretation is opposite, more matching the expected Column behaviour.

In that case, could you please move this to line 158 (you've made a change in the wrong snippet) and leave a comment above, explaining why you're overriding the child items constraints? Thanks 😊

@simona-anomis simona-anomis self-requested a review June 16, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants