Skip to content

Make WindowDemosActivity.kt compatible with Android 15 edge-to-edge enforcement #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ashnohe
Copy link
Contributor

@ashnohe ashnohe commented Feb 27, 2025

  • Update AppCompat dependency, because that allows partial E2E support for the ActionBar created with Theme.AppCompat.Light.DarkActionBar.
  • Ensure status bars icons are legible
  • Ensure RecylerView is inset via fitsSystemWindows

This makes the Activity compatible with the edge-to-edge enforcement, but more work could be done to beautify the UI. For example, the theme should use NoActionBar and instead create a custom toolbar that allows for greater control of heights and insets.

Before:
Screenshot 2025-02-27 at 1 11 39 PM

After:
Screenshot 2025-02-27 at 1 10 42 PM

@ashnohe ashnohe requested a review from yrezgui February 27, 2025 21:11
@ashnohe
Copy link
Contributor Author

ashnohe commented Mar 13, 2025

This change was incorporated into #275

@ashnohe ashnohe closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant