[Build] Reinforce the Gradle configuration for sample folder selection #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the project, a folder walk is done to list all the "samples" folders. This is done by checking the path in the settings.gradle.kts file. The path provided in the filter logic can be absolute and in this case it can include parents folders names, which can corrupt the check. Example: My project is cloned in the following folder: `<user-home>/android/samples/platform-samples` Then all the folders will be considered as samples and the Gradle build will failed at configuration step. Solution: Remove the parents folders part in the path during the filtering if the path is absolute.
yaraki
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
In the project, a folder walk is done to list all the "samples" folders. This is done by checking the path in the
settings.gradle.ktsfile.The path provided in the filter logic can be absolute and in this case it can include parents folders names, which can corrupt the check.
Example
My project is cloned in the following folder:
<user-home>/android/samples/platform-samplesThen all the folders will be considered as samples and the Gradle build will failed at configuration step.Problem is reproduced on my configuration: macOS 12.6.2
Solution
Remove the parents folders part in the path during the filtering if the path is absolute.