Skip to content

Conversation

@WonJoongLee
Copy link

What I have done and why

I removed the ComposableModifierFactory lint suppression because it no longer reports an error.

This lint warning was removed after the official recommendation for custom modifiers changed.

Reference : Custom modifier documentation

@WonJoongLee WonJoongLee requested a review from dturner as a code owner December 28, 2025 00:21
@gemini-code-assist
Copy link

Summary of Changes

Hello @WonJoongLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by removing an outdated lint suppression. The ComposableModifierFactory lint warning is no longer active due to changes in official recommendations for custom modifiers, making the @SuppressLint annotation redundant. Removing this suppression streamlines the codebase and ensures it adheres to the latest best practices without unnecessary annotations.

Highlights

  • Lint Suppression Removal: The @SuppressLint("ComposableModifierFactory") annotation has been removed from AppScrollbars.kt.
  • Code Cleanup: Associated TODO comments regarding the lint suppression have also been removed, cleaning up the codebase.
  • Updated Recommendations: This change reflects that the ComposableModifierFactory lint warning is no longer reported, aligning with updated official recommendations for custom modifiers in Jetpack Compose.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes an obsolete @SuppressLint("ComposableModifierFactory") annotation and its associated comments. As you've noted in the description, this lint suppression is no longer necessary due to the updated recommendations for creating custom modifiers in Jetpack Compose. This is a good code cleanup that improves maintainability. The change looks good.

@WonJoongLee WonJoongLee changed the title remove ComposableModifierFactory suppress lint Remove ComposableModifierFactory suppress lint Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant