Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retrofit from 2.9.0 to 2.11.0 #1548

Closed
wants to merge 2 commits into from

Conversation

SimonMarquis
Copy link
Contributor

Changelog: https://github.com/square/retrofit/blob/trunk/CHANGELOG.md

This is an updated version of the initial update PR that remained untouched for too long:

- Replace Jake Wharton's Kotlinx Serialization converter with new retrofit's `converter-kotlinx-serialization`.
- Remove custom Proguard rules that are now part of the dependency: https://github.com/square/retrofit/tree/trunk/retrofit-response-type-keeper#readme

Changelog: https://github.com/square/retrofit/blob/trunk/CHANGELOG.md
@dturner
Copy link
Collaborator

dturner commented Sep 5, 2024

Not sure why CI didn't run on this PR. Please could you update the badging to see if that kicks off the Build CI workflow?

@SimonMarquis
Copy link
Contributor Author

@dturner not sure why, but the summray still says:

This workflow requires approval from a maintainer. Learn more about approving workflows.
1 successful check

@SimonMarquis
Copy link
Contributor Author

I'll close/re-open the PR.

@SimonMarquis SimonMarquis reopened this Sep 5, 2024
@dturner
Copy link
Collaborator

dturner commented Sep 20, 2024

I had to create a separate PR to resolve the merge conflicts. #1623

@dturner dturner closed this Sep 20, 2024
@SimonMarquis SimonMarquis deleted the retrofit-2.11.0 branch September 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants