Use the version catalog as the source of truth for plugin IDs #1528
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IDs stated in the build-logic build script must exactly match the plugin IDs in the version catalog file. This solution reduces the inherent duplication. To avoid any IDE errors about missing plugin accessors when adding new plugins to the build-logic script, it's recommended to add the new ID in the version catalog first, then invoke Gradle (sync) in order to generate the accessor classes.
baksha97
reviewed
Sep 29, 2024
| @@ -58,59 +58,59 @@ tasks { | |||
| gradlePlugin { | |||
| plugins { | |||
| register("androidApplicationCompose") { | |||
| id = "nowinandroid.android.application.compose" | |||
| id = libs.plugins.nowinandroid.android.application.compose.get().pluginId | |||
There was a problem hiding this comment.
Can we also use these as the single source of truth for all id matchers used in the project?
There was a problem hiding this comment.
Which "matchers" are you referring to? In the plugins {} blocks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDs stated in the build-logic build script must exactly match the plugin IDs in the version catalog file. This solution reduces the inherent duplication.
To avoid any IDE errors about missing plugin accessors when adding new plugins to the build-logic script, it's recommended to add the new ID in the version catalog first, then invoke Gradle (sync) in order to generate the accessor classes.