Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Material3 to RC01 #993

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Conversation

florina-muntenescu
Copy link
Contributor

No description provided.

@florina-muntenescu florina-muntenescu requested a review from a team as a code owner October 7, 2022 17:04
Copy link
Member

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies are centrally managed and then copied into each sample. You should upgrade it in the global versions file in scripts/ or else it will be overriden the next time the samples are upgraded.

@@ -28,9 +28,9 @@ compileSdk = "33"
compose = "1.3.0-rc01"
compose-compiler = "1.3.2"
# @pin to be updated manually - check JetChat tests
compose-material3 = "1.0.0-beta03"
compose-material3 = "1.0.0-rc01"
# @pin to be updated manually - check JetChat tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the disclaimer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure who added it but I would think so

@astamato astamato requested a review from bentrengrove October 7, 2022 17:22
Copy link
Member

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that up

@florina-muntenescu florina-muntenescu merged commit 0a3ac4d into compose-latest Oct 8, 2022
@florina-muntenescu florina-muntenescu deleted the fm/material-rc01 branch October 8, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants