Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetcaster] Add TwoPane from accompanist/adaptive for player UI #947

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[Jetcaster] Add TwoPane from accompanist/adaptive for player UI #947

merged 2 commits into from
Feb 16, 2023

Conversation

alexvanyo
Copy link
Contributor

@alexvanyo alexvanyo commented Aug 17, 2022 •
edited
Loading

Using TwoPane from accompanist/adaptive to support postures and adaptive layout for the player screen in Jetcaster.

@alexvanyo alexvanyo force-pushed the av/jetcaster-two-pane branch from 1bdf4e6 to d18a2b7 Compare August 18, 2022 00:01
@alexvanyo alexvanyo mentioned this pull request Aug 18, 2022
Merged
@alexvanyo alexvanyo force-pushed the av/jetcaster-two-pane branch from d18a2b7 to 012270b Compare August 25, 2022 22:25
@alexvanyo alexvanyo changed the base branch from compose-latest to anomis/compose-latest-1.3.0-beta01 August 25, 2022 22:25
@alexvanyo alexvanyo force-pushed the av/jetcaster-two-pane branch from 012270b to 7887b67 Compare August 25, 2022 22:26
@alexvanyo alexvanyo marked this pull request as ready for review August 25, 2022 22:55
@alexvanyo alexvanyo requested a review from a team as a code owner August 25, 2022 22:55
@alexvanyo alexvanyo requested a review from IanGClifton August 25, 2022 22:55
Base automatically changed from anomis/compose-latest-1.3.0-beta01 to compose-latest August 29, 2022 05:12
@alexvanyo alexvanyo force-pushed the av/jetcaster-two-pane branch from 7887b67 to ba6f972 Compare August 31, 2022 23:36
@IanGClifton IanGClifton requested review from ricknout and removed request for IanGClifton September 9, 2022 23:43
@ricknout
Copy link
Contributor

I'd prefer if @Gurupreet could take a look at this given his experience in adding the functionality to Reply

@riggaroo
Copy link
Collaborator

This can probably be a PR into main @alexvanyo as it doesn't seem to be an alpha or beta of compose that its depending on.

@riggaroo riggaroo requested review from Gurupreet and removed request for ricknout September 25, 2022 19:40
@alexvanyo
Copy link
Contributor Author

@riggaroo accompanist/adaptive depends on Compose 1.3 for PlacementScope.coordinates, and I think we don't want main to depend on 1.3 yet?

@riggaroo
Copy link
Collaborator

Ah cool, yeah thats fine, thanks!

@stale
Copy link

stale bot commented Nov 25, 2022

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

@stale stale bot added the stale label Nov 25, 2022
@alexvanyo alexvanyo removed the stale label Nov 27, 2022
@stale
Copy link

stale bot commented Jan 26, 2023

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

@stale stale bot added the stale label Jan 26, 2023
@alexvanyo alexvanyo force-pushed the av/jetcaster-two-pane branch from ba6f972 to 99451e2 Compare January 31, 2023 21:38
@alexvanyo alexvanyo removed the stale label Jan 31, 2023
@alexvanyo alexvanyo requested a review from Gurupreet January 31, 2023 21:38
@alexvanyo alexvanyo changed the base branch from compose-latest to main January 31, 2023 21:38
@alexvanyo alexvanyo force-pushed the av/jetcaster-two-pane branch from 99451e2 to f7e9865 Compare January 31, 2023 21:46
@alexvanyo
Copy link
Contributor Author

@Gurupreet could you take another look here?

This is now targeted against main since Compose 1.3 is stable.

Gurupreet
Gurupreet approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@Gurupreet Gurupreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add screenshot for future to visualise table top etc

@alexvanyo
Copy link
Contributor Author

@Gurupreet added an image and updated the README in the latest commit!

@alexvanyo alexvanyo merged commit a5a0905 into main Feb 16, 2023
@alexvanyo alexvanyo deleted the av/jetcaster-two-pane branch February 16, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riggaroo riggaroo riggaroo left review comments

@Gurupreet Gurupreet Gurupreet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexvanyo @ricknout @riggaroo @Gurupreet