-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
bugSomething isn't workingSomething isn't workingtriage meIssue that needs to be triagedIssue that needs to be triaged
Description
Is there an existing issue for this?
- I have searched the existing issues
Is there a StackOverflow question about this issue?
- I have searched StackOverflow
Is this an issue related to one of the samples?
- Yes, this is a specific issue related to this samples repo.
Sample app
Jetcaster
What happened?
When opening a podcast details from the followed podcast list, the internal scroll state of the home screen is lost.
Screen_recording_20241112_161132.webm
This is likely due to the HomeScreen being called in two different places in the code, depending on this if statement:
compose-samples/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
Lines 325 to 357 in cb453e4
| if (podcastUri.isNullOrEmpty()) { | |
| HomeScreen( | |
| homeState = homeState, | |
| modifier = Modifier.fillMaxSize() | |
| ) | |
| } else { | |
| SupportingPaneScaffold( | |
| value = navigator.scaffoldValue, | |
| directive = navigator.scaffoldDirective, | |
| supportingPane = { | |
| val podcastDetailsViewModel = | |
| hiltViewModel<PodcastDetailsViewModel, PodcastDetailsViewModel.Factory>( | |
| key = podcastUri | |
| ) { | |
| it.create(podcastUri) | |
| } | |
| PodcastDetailsScreen( | |
| viewModel = podcastDetailsViewModel, | |
| navigateToPlayer = navigateToPlayer, | |
| navigateBack = { | |
| if (navigator.canNavigateBack()) { | |
| navigator.navigateBack() | |
| } | |
| }, | |
| showBackButton = navigator.isMainPaneHidden(), | |
| ) | |
| }, | |
| mainPane = { | |
| HomeScreen( | |
| homeState = homeState, | |
| modifier = Modifier.fillMaxSize() | |
| ) | |
| }, |
Relevant logcat output
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingtriage meIssue that needs to be triagedIssue that needs to be triaged