Remove withContext, refactor duplicate methods #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunjid
reviewed
Feb 27, 2023
...va/com/example/android/architecture/blueprints/todoapp/data/source/DefaultTasksRepository.kt
Show resolved
Hide resolved
tunjid
reviewed
Feb 27, 2023
...va/com/example/android/architecture/blueprints/todoapp/data/source/DefaultTasksRepository.kt
Show resolved
Hide resolved
manuelvicnt
reviewed
Feb 28, 2023
...va/com/example/android/architecture/blueprints/todoapp/data/source/DefaultTasksRepository.kt
Show resolved
Hide resolved
.../example/android/architecture/blueprints/todoapp/data/source/remote/TasksRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
tunjid
approved these changes
Feb 28, 2023
manuelvicnt
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what I've done and why:
withContext.withContextrequires the caller to know something about the execution of the enclosed method(s) (e.g. it is cpu or disk bound). In this case, these calls are redundant because the only I/O bound operations are handled by Room, which will already move those operations onto the I/O thread, so we don't need to be concerned with it.completeTask(task: Task)andactivateTask(task: Task)methods in favour of using the existingcompleteTask(taskId: String)andactivateTask(taskId: String). This creates a smaller API surface which is more loosely coupled.Taskto be immutable. Having a mutable model is an anti-pattern as it allows callers to modify the model, which violates SSOT.