Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit #728

Open
wants to merge 8 commits into
base: dagger-android
Choose a base branch
from
Open

Conversation

aceiro
Copy link

@aceiro aceiro commented Apr 11, 2020

Hi @JoseAlcerreca

I did some changes in branch dagger-android and I would like to know if it is possible contribute for your project.
The main changes that I did were:

  • Added Retrofit compatibility using a public API - Placeholder
  • Added feature-flag to be used in compile variant - in this case, we can choice in Retrofit API and yours local and remote repository that you done
  • Added one item for task_fragment_menu.xml

So, let me know it like this changes. If was possible I can merge for other branch - based on dagger-android.

Have a nice day !

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Author

@aceiro aceiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reverting some mistakes in original code

@aceiro aceiro closed this Apr 12, 2020
@aceiro aceiro reopened this Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants