Tunein dev #718
Draft
Tunein dev #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update todo-mvp README.md Refactored the content around a new structure, with new standard titles used for each sample Fixed various grammar issues Applied formatting Additional explanations and links where appropriate Introduced pre-requisite topics * Update README.md Removed a redundant sentence. * copies Firebase Test Lab results to CIRCLE_TEST_REPORTS * Replaced deprecated attribute * Bumps versions and fixes annotation imports * Fixes toolbar title not being persisted after rotation * Fixes navigation issue android#287 * Bumps circle CI Android dependencies * Fixes comment in test * Bumps versions in travis.yml * Moving the setting of the AddEditTaskPresenter in the constructor. Tests added to check that the presenter is set to the view. * Removing the `_id` column and making `entryid` primary key. Moved the `TasksLocalDataSourceTest` to correct package. * Fixed Firebase Test Lab script * Tries to fix circle adding google repo * Buildtools 26 is mandatory now, apparently * More CI fixes * CI caught some merge errors + circle fix
* Update todo-mvp README.md Refactored the content around a new structure, with new standard titles used for each sample Fixed various grammar issues Applied formatting Additional explanations and links where appropriate Introduced pre-requisite topics * Update README.md Removed a redundant sentence. * copies Firebase Test Lab results to CIRCLE_TEST_REPORTS * Replaced deprecated attribute * Bumps versions and fixes annotation imports * Fixes toolbar title not being persisted after rotation * Fixes navigation issue android#287 * Bumps circle CI Android dependencies * Fixes comment in test * Bumps versions in travis.yml * Moving the setting of the AddEditTaskPresenter in the constructor. Tests added to check that the presenter is set to the view. * Removing the `_id` column and making `entryid` primary key. Moved the `TasksLocalDataSourceTest` to correct package. * First commit: MPV with Room * Readme updated * Readme updated * Fixing CI * Fixing tests for local repository * Using Idling resources for tests, for commands that are executed on the background thread * comments updated * Fixed Firebase Test Lab script * fix typo in androidTest * Fix typo (android#415) - Change "compliment" to "complement" * Fixed the typo (android#425) * Tries to fix circle adding google repo * Buildtools 26 is mandatory now, apparently * More CI fixes * CI caught some merge errors + circle fix * Fixed Firebase Test Lab script (android#440) * Updates room branch to API 26, Espresso, Arch Components * Adds google m2 repository * Adding google() to repositories * Reverts to todo-mvp's README
Fixes links of todo-databinding sample
…raries version upgrade
…tween app sessions
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to persist changes to db to maintain todos across app sessions
Add ability to sort by priority and todo name
Display of priority under todos in the todo list