-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the version of Kotlin and Gradle #607
base: todo-mvp-kotlin
Are you sure you want to change the base?
Update the version of Kotlin and Gradle #607
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
todoapp/build.gradle
Outdated
} | ||
dependencies { | ||
classpath "com.android.tools.build:gradle:$gradlePluginVersion" | ||
classpath "com.android.tools.build:gradle:3.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of hardcoding this here, why not update the gradlePluginVersion variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking, I fixed it. Kotlin ver1.3.10 was released, so I also updated Kotlin to the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few merge conflicts today
@dazza5000 Thanks, I fixed merge conflicts, so please check it out. |
296744f
to
759d758
Compare
Hi, I updated app/build.gradle and gradle-wrapper.properties by the latest Kotlin/Gradle version.
Somehow I couldn't resolve the dependency of 'android-P', so I also replaced it with 28.