Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of Kotlin and Gradle #607

Open
wants to merge 3 commits into
base: todo-mvp-kotlin
Choose a base branch
from

Conversation

maeda-kazuya
Copy link

Hi, I updated app/build.gradle and gradle-wrapper.properties by the latest Kotlin/Gradle version.
Somehow I couldn't resolve the dependency of 'android-P', so I also replaced it with 28.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@maeda-kazuya
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

}
dependencies {
classpath "com.android.tools.build:gradle:$gradlePluginVersion"
classpath "com.android.tools.build:gradle:3.2.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of hardcoding this here, why not update the gradlePluginVersion variable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking, I fixed it. Kotlin ver1.3.10 was released, so I also updated Kotlin to the version.

Copy link

@dazza5000 dazza5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few merge conflicts today

@maeda-kazuya
Copy link
Author

@dazza5000 Thanks, I fixed merge conflicts, so please check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants