This repository was archived by the owner on Nov 14, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 14, 2018. It is now read-only.
Camera2 Extension #472
Description
I'd like to propose an extension to get a camera by direction.
the implementation would be something like that :
enum class FACING(val direction: Int) {
FRONT_CAMERA(CameraCharacteristics.LENS_FACING_FRONT), REAR_CAMERA(CameraCharacteristics.LENS_FACING_BACK)
}
@RequiresApi(21)
fun CameraManager.getCameraByDirection(direction: FACING): Pair<String, CameraCharacteristics> {
for (cameraId in this.cameraIdList) {
val characteristics = this.getCameraCharacteristics(cameraId)
val cameraDirection = characteristics.get(CameraCharacteristics.LENS_FACING)
if (cameraDirection != null && cameraDirection == direction.direction) {
return Pair(cameraId, characteristics)
}
}
throw RuntimeException("Camera Not Found")
}
Usage :
val manager = context.getSystemService(Context.CAMERA_SERVICE) as CameraManager
val (cameraId, cameraCharacteristics) = manager.getCameraByDirection(REAR_CAMERA)
Activity
kioba commentedon Aug 14, 2018
As far as I know, there could be multiple
LENS_FACINGandLENS_FACING_BACKhardware but we always return the first one.we have to also take
LENS_FACING_EXTERNALinto consideration https://developer.android.com/reference/android/hardware/camera2/CameraMetadata.html#LENS_FACING_EXTERNALThe
Pairreturn types indicate that we are doing too many at once.I would suggest separating the implementation into two part.
Now anyone can use their own algorithm to find the best fitting camera for their usecase.
And because
Sequenceis lazy evaluated it cost less to find the right element.CameraCharacteristicswithis*andisNot*properties.just one example:
Muhannad508 commentedon Aug 14, 2018
Thanks @kioba for your inputs . But it seems hardware APIs go beyond the scope of android-ktx .
as stated in the below link :
#373
kioba commentedon Aug 14, 2018
@Muhannad508 thanks for the link! That is good to know 👍