Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Add key management capabilities #1446

Closed
wants to merge 24 commits into from
Closed

Add key management capabilities #1446

wants to merge 24 commits into from

Conversation

Skrilltrax
Copy link
Member

@Skrilltrax Skrilltrax commented Jun 26, 2021

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

WIP

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I formatted the code ./gradlew spotlessApply
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

@Skrilltrax
Copy link
Member Author

Skrilltrax commented Jul 5, 2021

Things we should probably add in this pr

  • Allow entering passphrase for decryption.
  • Show key details when the key is imported.
  • Allow importing key when the repository is cloned from a remote source.
  • Show a snackbar to import key on the decryption screen if the key is not present. (Useful for migration)
  • Add an option in settings to import extra keys
  • Support finding keys by hex fingerprint and identity email

Base automatically changed from gopenpgp to develop July 11, 2021 17:22
@msfjarvis msfjarvis force-pushed the import-keys branch 2 times, most recently from 3b838c4 to 2d74bda Compare July 12, 2021 12:06
@msfjarvis
Copy link
Member

I've pushed up a slightly more useful version of the key lookup mechanism, but there's still a lot left to do on that front. One option that we could potentially explore is to leverage GpgIdentifier rather than trying to reimplement it.

Skrilltrax and others added 6 commits July 31, 2021 14:20
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@msfjarvis
Copy link
Member

Closing since it's being broken down into separate PRs.

@msfjarvis msfjarvis closed this Aug 16, 2021
@msfjarvis msfjarvis deleted the import-keys branch October 9, 2021 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants