This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Set 10 second timeout on JGit transport commands #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
added
A-Git
fmeum
approved these changes
Dec 3, 2020
msfjarvis
removed
the
S-waiting-on-review
msfjarvis
added a commit
that referenced
this pull request
Dec 21, 2020
* GitOperation: set a 10 second connection timeout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 77e77be) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Sets a reasonable 10 second timeout on JGit transport commands to ensure they don't appear "stuck" for a long time.
💡 Motivation and Context
I've received complaints often and also personally observed that many types of connection issues cause JGit to just stall until the default timeout is reached which takes far too long.
💚 How did you test it?
Verified that enabling a VPN and then trying to pull a repository from my local computer over LAN caused the connection to timeout faster.
📝 Checklist
🔮 Next steps
Add support for an additional fallback remote which can be used as a failover when the primary one is unavailable. For my case, the primary one will be my local computer over LAN, and the fallback would be a separately hosted Git repository available over the internet.