Fix CUDA KV cache clear on non-host buffers#4
Open
double-thinker wants to merge 1 commit intoandrijdavid:mainfrom
Open
Fix CUDA KV cache clear on non-host buffers#4double-thinker wants to merge 1 commit intoandrijdavid:mainfrom
double-thinker wants to merge 1 commit intoandrijdavid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR was assisted by AI but has been human-reviewed.
This fixes a CUDA crash when running with --gpu cuda.
The issue was caused by host-side memset/memmove on KV cache tensors (kv_self_k, kv_self_v) that can live in non-host backend buffers (CUDA/Vulkan/Metal). In that case, ggml_get_data() may not return host-safe memory, which can segfault.
Crash path (reproducible on GTX 1080 Ti, sm_61):
gdb points to:
Fix