Skip to content

Exclude none values when creating and updating #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Exclude none values when creating and updating #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/healthchecks_io/client/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ async def create_check(self, new_check: CheckCreate) -> Check:
"""
request_url = self._get_api_request_url("checks/")
response = self.check_response(
await self._client.post(request_url, json=new_check.dict())
await self._client.post(request_url, json=new_check.dict(exclude_none=True))
)
return Check.from_api_result(response.json())

Expand All @@ -118,7 +118,8 @@ async def update_check(self, uuid: str, update_check: CheckCreate) -> Check:
request_url = self._get_api_request_url(f"checks/{uuid}")
response = self.check_response(
await self._client.post(
request_url, json=update_check.dict(exclude_unset=True)
request_url,
json=update_check.dict(exclude_unset=True, exclude_none=True),
)
)
return Check.from_api_result(response.json())
Expand Down
7 changes: 5 additions & 2 deletions src/healthchecks_io/client/sync_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def create_check(self, new_check: CheckCreate) -> Check:
"""
request_url = self._get_api_request_url("checks/")
response = self.check_response(
self._client.post(request_url, json=new_check.dict())
self._client.post(request_url, json=new_check.dict(exclude_none=True))
)
return Check.from_api_result(response.json())

Expand All @@ -163,7 +163,10 @@ def update_check(self, uuid: str, update_check: CheckCreate) -> Check:
"""
request_url = self._get_api_request_url(f"checks/{uuid}")
response = self.check_response(
self._client.post(request_url, json=update_check.dict(exclude_unset=True))
self._client.post(
request_url,
json=update_check.dict(exclude_unset=True, exclude_none=True),
)
)
return Check.from_api_result(response.json())

Expand Down