Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower.json main script path update #553

Closed
wants to merge 1 commit into from

Conversation

tomasbulva
Copy link

Hi There,
I'm sorry for unsolicited pull request. There is super minor thing that was messing up our project. As Sugar is being build into the "release" folder the "bower.json – main" entry-point does not reflect this and thus automated services (in our case grunt wiredep) that depend on this data can't see sugar lib.

Thank you,
Tomas

andrewplummer added a commit that referenced this pull request Aug 2, 2016
@andrewplummer
Copy link
Owner

Hi, really sorry about this... I was having issues with the entry points and I had to make a quick revert, which I think lead to this situation.

I've updated the "main" entry point in bower.json and bumped the version to 1.5.1. This should work for you.

Unfortunately the pull request didn't merge because I'm in a separate 1.5 branch now so I had to make the change myself.

Anyway thanks for finding this!

@tomasbulva
Copy link
Author

Hi,
Thank you for the fix.

Tomas Bulva
630-841-8042
tom.bulva@gmail.com

On Aug 1, 2016, at 7:00 PM, Andrew Plummer notifications@github.com wrote:

Hi, really sorry about this... I was having issues with the entry points and I had to make a quick revert, which I think lead to this situation.

I've updated the "main" entry point in bower.json and bumped the version to 1.5.1. This should work for you.

Unfortunately the pull request didn't merge because I'm in a separate 1.5 branch now so I had to make the change myself.

Anyway thanks for finding this!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #553 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AB9B3bXco2Eu1HOYYSNaTYjiOHCLoDMNks5qbqS9gaJpZM4JaGE-.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants